[webkit-reviews] review requested: [Bug 189318] [Curl] Response with collect authentication scheme for authentication challenge. : [Attachment 349489] PATCH

[bugzilla-daemon at webkit.org]

Basuke Suzuki <Basuke.Suzuki at sony.com> has asked  for review:
Bug 189318: [Curl] Response with collect authentication scheme for
authentication challenge.
https://bugs.webkit.org/show_bug.cgi?id=189318

Attachment 349489: PATCH

https://bugs.webkit.org/attachment.cgi?id=349489&action=review




--- Comment #2 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 349489
  --> https://bugs.webkit.org/attachment.cgi?id=349489
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=349489&action=review

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:335
> +std::optional<Credential> ResourceHandle::getCredential(const
ResourceRequest& request, bool redirect)

These changes follow the Mac port implementation.

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:403
> +    }

To set the default authentication in the credential storage.