[webkit-reviews] review requested: [Bug 189519] Introduce WebCore::DataView, a safer replacement for IPC::DataReference : [Attachment 349463] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has asked  for review:
Bug 189519: Introduce WebCore::DataView, a safer replacement for
IPC::DataReference
https://bugs.webkit.org/show_bug.cgi?id=189519

Attachment 349463: Patch

https://bugs.webkit.org/attachment.cgi?id=349463&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 349463
  --> https://bugs.webkit.org/attachment.cgi?id=349463
Patch

*.messages.in always uses DataReferences right now.  We create a
SharedBufferDataReference as that DataReference right now where we know we are
doing nothing but encoding it and don't want to copy the data into one segment.
 This leaves us to manually have to know we can't call .data() on some
DataReferences but not others.	This is the problem this patch is intended to
fix.
"I want to just assume all my data is in one segment" is also the reason we
have SharedBuffer::data, which this will also help get rid of.	That's another
source of inefficient code.
Re-setting r? hoping Chris will reconsider.