[webkit-reviews] review denied: [Bug 189519] Introduce WebCore::DataView, a safer replacement for IPC::DataReference : [Attachment 349463] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 189519: Introduce WebCore::DataView, a safer replacement for
IPC::DataReference
https://bugs.webkit.org/show_bug.cgi?id=189519

Attachment 349463: Patch

https://bugs.webkit.org/attachment.cgi?id=349463&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 349463
  --> https://bugs.webkit.org/attachment.cgi?id=349463
Patch

As far as I understand it (please correct me if I am wrong), there is no cost
to calling data() / size() on the recipient side. On the recipient side, there
is always only 1 segment. Therefore, requiring recipients to iterate over
segments even though there is only one seems wrong and confusing.
Recipients that need a buffer may actually iterate unnecessarily over the
dataView.

My understanding that is it would only be bad to call data() / size() on sender
side, but this is not something that people do.