[webkit-reviews] review granted: [Bug 189502] [WHLSL] Improve test suite type safety : [Attachment 349429] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Thomas Denney
<tdenney at apple.com>'s request for review:
Bug 189502: [WHLSL] Improve test suite type safety
https://bugs.webkit.org/show_bug.cgi?id=189502

Attachment 349429: Patch

https://bugs.webkit.org/attachment.cgi?id=349429&action=review




--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 349429
  --> https://bugs.webkit.org/attachment.cgi?id=349429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349429&action=review

> Tools/WebGPUShadingLanguageRI/All.js:105
> +load("IsBitwiseEquivalent.js");

Why not put this in Casts.js?

> Tools/WebGPUShadingLanguageRI/Casts.js:126
> +	   throw new Error(`${value} was casted to ${castedValue}`);

This message is not particularly clear why it is an error condition.