[webkit-reviews] review granted: [Bug 189514] [Cocoa] Dictionary hangs when searching : [Attachment 349420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 13:00:17 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 189514: [Cocoa] Dictionary hangs when searching
https://bugs.webkit.org/show_bug.cgi?id=189514

Attachment 349420: Patch

https://bugs.webkit.org/attachment.cgi?id=349420&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349420
  --> https://bugs.webkit.org/attachment.cgi?id=349420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349420&action=review

> Source/WebCore/page/cocoa/SettingsBaseCocoa.mm:59
>      RetainPtr<CFNumberRef> yes = adoptCF(CFNumberCreate(kCFAllocatorDefault,
kCFNumberIntType, &one));

'yes' is now unused.


More information about the webkit-reviews mailing list