[webkit-reviews] review granted: [Bug 189491] Update webkit-webgl-test-harness.js for more details on WebGL 2 conformance tests part 3 : [Attachment 349368] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 11 12:53:26 PDT 2018
Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 189491: Update webkit-webgl-test-harness.js for more details on WebGL 2
conformance tests part 3
https://bugs.webkit.org/show_bug.cgi?id=189491
Attachment 349368: Patch
https://bugs.webkit.org/attachment.cgi?id=349368&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 349368
--> https://bugs.webkit.org/attachment.cgi?id=349368
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=349368&action=review
> LayoutTests/webgl/2.0.0/resources/webkit-webgl-test-harness.js:53
> + list("[ " + resultNum + ": PASS ] " + msg, "green");
The modern JS way to do these strings is:
`[ ${resultNum}: PASS ] ${msg}`
More information about the webkit-reviews
mailing list