[webkit-reviews] review granted: [Bug 5968] Add support for spreadMethod=reflect and repeat on SVG gradients (for CoreGraphics platforms) : [Attachment 349405] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 5968: Add support for spreadMethod=reflect and repeat on SVG gradients (for
CoreGraphics platforms)
https://bugs.webkit.org/show_bug.cgi?id=5968

Attachment 349405: Patch

https://bugs.webkit.org/attachment.cgi?id=349405&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349405
  --> https://bugs.webkit.org/attachment.cgi?id=349405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349405&action=review

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:118
> +		   FloatPoint gradientVectorNorm(data.point1 - data.point0);

Normally we'd use a FloatSize to represent the delta between two points, but
sadly we haven't implemented .dot() for FloatSize.

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:120
> +		   CGFloat angle = acos(gradientVectorNorm.dot(FloatPoint(1,
0)));

Rather than FloatPoint(1, 0) you can say { 1, 0 } to let the compiler deduce
the type.