[webkit-reviews] review granted: [Bug 189505] [WPE][GTK] API documentation is unclear about how to modify requests before sending them : [Attachment 349403] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 189505: [WPE][GTK] API documentation is unclear about how to modify
requests before sending them
https://bugs.webkit.org/show_bug.cgi?id=189505

Attachment 349403: Patch

https://bugs.webkit.org/attachment.cgi?id=349403&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 349403
  --> https://bugs.webkit.org/attachment.cgi?id=349403
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349403&action=review

I've been confused by this before too. Thanks.

> Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:128
> + * Modifications to the returned object are <emphasis>not</emphasis> taken

Hm, gtk-doc removed support for XML a long time ago. Are you sure this is
actually going to work? I suspect the output will literally say
<emphasis>not</emphasis>. Do you have some recent HTML example of this working?

I think it's supposed to be markdown instead?