[webkit-reviews] review granted: [Bug 189462] [GStreamer] use-after-free in MockVideoCaptureSource : [Attachment 349313] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 189462: [GStreamer] use-after-free in MockVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=189462

Attachment 349313: Patch

https://bugs.webkit.org/attachment.cgi?id=349313&action=review




--- Comment #16 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 349313
  --> https://bugs.webkit.org/attachment.cgi?id=349313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349313&action=review

>
Source/WebCore/platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.c
pp:57
> +	   auto buffer =
adoptGRef(gst_buffer_new_wrapped(g_memdup(data.releaseBuffer().leakPtr(),
size), size));

If you do a g_memdup you shouldn't leakPtr() but get().