[webkit-reviews] review granted: [Bug 189382] [macOS] [WK2] Support changing foreground colors via color panel : [Attachment 349376] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 189382: [macOS] [WK2] Support changing foreground colors via color panel
https://bugs.webkit.org/show_bug.cgi?id=189382

Attachment 349376: Patch

https://bugs.webkit.org/attachment.cgi?id=349376&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 349376
  --> https://bugs.webkit.org/attachment.cgi?id=349376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349376&action=review

> Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:276
> +    checkFontColorAtStartAndEndWithInputEvents("rgb(255, 0, 0)");

Let's also add an assertion to make sure we're inserting a font element instead
of a span in this case.

> Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:287
> +    checkFontColorAtStartAndEndWithInputEvents("rgb(204, 179, 51)");

Ditto.