[webkit-reviews] review denied: [Bug 189485] Web Inspector: change WI.ColorWheel to use conic-gradient() : [Attachment 349338] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 10 17:46:39 PDT 2018
Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 189485: Web Inspector: change WI.ColorWheel to use conic-gradient()
https://bugs.webkit.org/show_bug.cgi?id=189485
Attachment 349338: Patch
https://bugs.webkit.org/attachment.cgi?id=349338&action=review
--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 349338
--> https://bugs.webkit.org/attachment.cgi?id=349338
Patch
r-, because it looks like this patch changes the behavior of the wheel. For
example, try the following in shipping Safari and with this patch applied:
1. Bring up the color picker
2. Enter 255 for each channel, in order: R, then, G, then B.
3. Note the "crosshairs" location, and color wheel appearance.
See attached screenshots.
More information about the webkit-reviews
mailing list