[webkit-reviews] review granted: [Bug 189475] [iOS] Unable to change the value of select elements while preserving focus state : [Attachment 349332] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 189475: [iOS] Unable to change the value of select elements while
preserving focus state
https://bugs.webkit.org/show_bug.cgi?id=189475

Attachment 349332: Patch

https://bugs.webkit.org/attachment.cgi?id=349332&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 349332
  --> https://bugs.webkit.org/attachment.cgi?id=349332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349332&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:458
> +    // However, unlike active focus state, it may be safely reset to 0.

Probably need to define "safely" here. "Without impact to existing API
contracts?"