[webkit-reviews] review granted: [Bug 189481] Regression(PSON): WebView is blank when navigating back cross-process on iOS : [Attachment 349325] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 189481: Regression(PSON): WebView is blank when navigating back
cross-process on iOS
https://bugs.webkit.org/show_bug.cgi?id=189481

Attachment 349325: Patch

https://bugs.webkit.org/attachment.cgi?id=349325&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 349325
  --> https://bugs.webkit.org/attachment.cgi?id=349325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349325&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:526
> +    if (auto* drawingArea = m_page.drawingArea())

I bet these aren't the only null checks we need.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6003
> +    if (m_isSuspended == suspended)
> +	   return;

Suspended just means PSON-y suspension, not e.g. normal process suspension?