[webkit-reviews] review granted: [Bug 189458] [Payment Request] Use JSValueInWrappedObject for PaymentResponse's details attribute : [Attachment 349290] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 10 11:58:22 PDT 2018
youenn fablet <youennf at gmail.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 189458: [Payment Request] Use JSValueInWrappedObject for PaymentResponse's
details attribute
https://bugs.webkit.org/show_bug.cgi?id=189458
Attachment 349290: Patch
https://bugs.webkit.org/attachment.cgi?id=349290&action=review
--- Comment #17 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 349290
--> https://bugs.webkit.org/attachment.cgi?id=349290
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=349290&action=review
>
LayoutTests/http/tests/paymentrequest/payment-response-reference-cycle-leak.htt
ps.html:26
> + return "leaked an unexpected number of nodes: " + leaks + " leaks in " +
repetitions + " runs";
If that pattern works and is not flaky, maybe this should be put in its own
script so that we can reuse it elsewhere.
More information about the webkit-reviews
mailing list