[webkit-reviews] review denied: [Bug 189469] Try to fix the iOSMac build : [Attachment 349297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 09:06:08 PDT 2018


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Tim Horton
<thorton at apple.com>'s request for review:
Bug 189469: Try to fix the iOSMac build
https://bugs.webkit.org/show_bug.cgi?id=189469

Attachment 349297: Patch

https://bugs.webkit.org/attachment.cgi?id=349297&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 349297
  --> https://bugs.webkit.org/attachment.cgi?id=349297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349297&action=review

> Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm:85
> +    Vector<PluginModuleInfo> plugins =
WebKit::toImpl(contextRef)->pluginInfoStore().plugins();

In file included from
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sou
rces/UnifiedSource14-mm.mm:5:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.
mm:85:12: error: unknown type name 'PluginModuleInfo'; did you mean
'WebKit::PluginModuleInfo'?
    Vector<PluginModuleInfo> plugins =
WebKit::toImpl(contextRef)->pluginInfoStore().plugins();
	   ^~~~~~~~~~~~~~~~
	   WebKit::PluginModuleInfo
In file included from
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sou
rces/UnifiedSource14-mm.mm:5:
In file included from
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.
mm:40:
In file included from
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebProcessPool.h:30:
In file included from
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/APIProcessPoolConfiguratio
n.h:30:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
:71:8: note: 'WebKit::PluginModuleInfo' declared here
struct PluginModuleInfo;
       ^
1 error generated.


More information about the webkit-reviews mailing list