[webkit-reviews] review requested: [Bug 182230] [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To) : [Attachment 349311] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 08:59:30 PDT 2018


Frédéric Wang (:fredw) <fred.wang at free.fr> has asked  for review:
Bug 182230: [CSSOM View] Handle the scrollingElement in
Element::scroll(Left/Top/Width/Height/To)
https://bugs.webkit.org/show_bug.cgi?id=182230

Attachment 349311: Patch

https://bugs.webkit.org/attachment.cgi?id=349311&action=review




--- Comment #53 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Created attachment 349311

  --> https://bugs.webkit.org/attachment.cgi?id=349311&action=review

Patch

(In reply to Frédéric Wang (:fredw) from comment #52)
> (In reply to Truitt Savell from comment #51)
> > Looks like this patch https://trac.webkit.org/changeset/235806/webkit
> 
> Thanks, I wonder whether it's related to the current implementation of
> Document::isBodyPotentiallyScrollable (see bug 182292).
> 
> I guess a workaround for now would be to use documentElement instead of
> scrollingElement in
> LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html

I stand corrected. I thought the issue was with
tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html...
For fast-scroll-iframe-latched-mainframe.html, just replacing document.body
with document.scrollingElement avoids the flackiness for me.


More information about the webkit-reviews mailing list