[webkit-reviews] review denied: [Bug 189462] [GStreamer] use-after-free in MockVideoCaptureSource : [Attachment 349303] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 189462: [GStreamer] use-after-free in MockVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=189462

Attachment 349303: Patch

https://bugs.webkit.org/attachment.cgi?id=349303&action=review




--- Comment #10 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 349303
  --> https://bugs.webkit.org/attachment.cgi?id=349303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349303&action=review

>
Source/WebCore/platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.c
pp:58
> +	   auto gstSample =
adoptGRef(gst_sample_new(gst_buffer_new_wrapped(data.releaseBuffer().leakPtr(),
> +	       size), caps.get(), nullptr, nullptr));

I think we're leaking the buffer here. gst_buffer_new_wrapped is [transfer
full] and gst_sample_new receives [transfer none].