[webkit-reviews] review granted: [Bug 189465] XMLHttpRequest: overrideMimeType should not update the response's "Content-Type" header : [Attachment 349291] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 189465: XMLHttpRequest: overrideMimeType should not update the response's
"Content-Type" header
https://bugs.webkit.org/show_bug.cgi?id=189465

Attachment 349291: Patch

https://bugs.webkit.org/attachment.cgi?id=349291&action=review




--- Comment #3 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 349291
  --> https://bugs.webkit.org/attachment.cgi?id=349291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349291&action=review

> Source/WebCore/ChangeLog:9
> +	   response's "Content-Type" header anymore.

Are you able to provide a link to a spec change (github issue or something)
showing that change?

> Source/WebCore/xml/XMLHttpRequest.cpp:-969
> -	   m_response.setHTTPHeaderField(HTTPHeaderName::ContentType,
m_mimeTypeOverride);

Can you please also remove the FIXME comment from
XMLHttpRequest::didReceiveData? (I guess setting the m_responseEncoding from
m_mimeTypeOverride is still valid, right?).