[webkit-reviews] review granted: [Bug 189457] [Cocoa] Use more bridging casts in TestWebKitAPI : [Attachment 349275] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 8 20:42:26 PDT 2018
Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 189457: [Cocoa] Use more bridging casts in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=189457
Attachment 349275: Patch
https://bugs.webkit.org/attachment.cgi?id=349275&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 349275
--> https://bugs.webkit.org/attachment.cgi?id=349275
Patch
Thanks. These look good. I am working on a patch that turns on ARC for
TestWebKitAPI and this should have a good overlap with the changes needed for
that. Under ARC these get checked a little bit more so it might catch some
mistakes that are harmless in non-ARC.
More information about the webkit-reviews
mailing list