[webkit-reviews] review granted: [Bug 188722] Many textarea tests leak documents because Document::removeFocusNavigationNodeOfSubtree() can trigger a Document retain cycle : [Attachment 349260] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 188722: Many textarea tests leak documents because
Document::removeFocusNavigationNodeOfSubtree() can trigger a Document retain
cycle
https://bugs.webkit.org/show_bug.cgi?id=188722

Attachment 349260: Patch

https://bugs.webkit.org/attachment.cgi?id=349260&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 349260
  --> https://bugs.webkit.org/attachment.cgi?id=349260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349260&action=review

> Source/WebCore/dom/Document.cpp:4275
> +	   m_focusNavigationStartingNode = newNode;

I would have preferred to use a ternary operator here instwad