[webkit-reviews] review granted: [Bug 189452] Clean up code related to Document node removal : [Attachment 349258] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 8 13:15:25 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 189452: Clean up code related to Document node removal
https://bugs.webkit.org/show_bug.cgi?id=189452

Attachment 349258: Patch

https://bugs.webkit.org/attachment.cgi?id=349258&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 349258
  --> https://bugs.webkit.org/attachment.cgi?id=349258
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349258&action=review

> Source/WebCore/dom/Document.h:760
> +    enum class NodeRemoval { Node, ChildrenOfNode };

Do we care about shrinking the width of enums that are only passed around as
arguments, and not stored anywhere? (If so, this should be 8 bits)


More information about the webkit-reviews mailing list