[webkit-reviews] review granted: [Bug 189400] Unify most of the WebKit C API sources : [Attachment 349123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 17:09:20 PDT 2018


Alex Christensen <achristensen at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 189400: Unify most of the WebKit C API sources
https://bugs.webkit.org/show_bug.cgi?id=189400

Attachment 349123: Patch

https://bugs.webkit.org/attachment.cgi?id=349123&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 349123
  --> https://bugs.webkit.org/attachment.cgi?id=349123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349123&action=review

Windows failure looks unrelated.

> Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:243
> +		  
writeToFile(WebKit::NetworkCache::Data(sourceJSON.characters8(),
serializedLength));

Would just an initializer list work here?


More information about the webkit-reviews mailing list