[webkit-reviews] review granted: [Bug 189390] Add support for unified plan transceivers : [Attachment 349154] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189390: Add support for unified plan transceivers
https://bugs.webkit.org/show_bug.cgi?id=189390

Attachment 349154: Patch

https://bugs.webkit.org/attachment.cgi?id=349154&action=review




--- Comment #13 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 349154
  --> https://bugs.webkit.org/attachment.cgi?id=349154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349154&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:156
>	   if (kind != "audio" && kind != "video")

Nit: might as well fix these while you are here: "audio"_s && "video"_s

> LayoutTests/ChangeLog:45
> +2018-09-06  Daniel Bates  <dabates at apple.com>
> +
> +	   [iOS] Add a test to ensure that DOM keyup events have the correct
details
> +	   https://bugs.webkit.org/show_bug.cgi?id=189327
> +
> +	   Reviewed by Wenson Hsieh.
> +
> +	   Until we fix <rdar://problem/35282761> DOM keyup events will have
incorrect details on iOS
> +	   when dispatched in response to a hardware keyboard press. For now,
land expected failure results.
> +
> +	   * fast/events/ios/keyup-expected.txt: Added.
> +	   * fast/events/ios/keyup.html: Added.
> +	   * resources/ui-helper.js:
> +	   (window.UIHelper.typeCharacter): Escape backslash characters in
order to build up
> +	   a well-formed UI script to evaluate.
> +

Oops