[webkit-reviews] review requested: [Bug 189427] RealtimeOutgoingVideoSourceCocoa should use VTImageRotationSession to rotate CVPixelBuffers : [Attachment 349177] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 7 13:39:00 PDT 2018
youenn fablet <youennf at gmail.com> has asked for review:
Bug 189427: RealtimeOutgoingVideoSourceCocoa should use VTImageRotationSession
to rotate CVPixelBuffers
https://bugs.webkit.org/show_bug.cgi?id=189427
Attachment 349177: Patch
https://bugs.webkit.org/attachment.cgi?id=349177&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 349177
--> https://bugs.webkit.org/attachment.cgi?id=349177
Patch
Code following more or less ImageDecoderAVFObjC::storeSampleBuffer.
Maybe I should check return error for VTImageRotationSessionCreate,
VTImageRotationSessionSetProperty, CVPixelBufferPoolCreate and
CVPixelBufferPoolCreatePixelBuffer?
More information about the webkit-reviews
mailing list