[webkit-reviews] review granted: [Bug 189151] [DFG] DFG should handle String#toString : [Attachment 349041] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 189151: [DFG] DFG should handle String#toString
https://bugs.webkit.org/show_bug.cgi?id=189151

Attachment 349041: Patch

https://bugs.webkit.org/attachment.cgi?id=349041&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 349041
  --> https://bugs.webkit.org/attachment.cgi?id=349041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349041&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOperations.cpp:2028
> +    auto* stringObject = jsDynamicCast<StringObject*>(vm, argument);
> +    if (stringObject)

style nit: I think this is cleaner if you just did:
if (auto* stringObject = jsDynamicCast<StringObject*>(vm, argument)) ...

> Source/JavaScriptCore/dfg/DFGOperations.h:196
> +JSCell* JIT_OPERATION operationStringValueOf(ExecState*, EncodedJSValue);

Why not return JSString*?