[webkit-reviews] review granted: [Bug 182230] [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To) : [Attachment 349118] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 182230: [CSSOM View] Handle the scrollingElement in
Element::scroll(Left/Top/Width/Height/To)
https://bugs.webkit.org/show_bug.cgi?id=182230

Attachment 349118: Patch

https://bugs.webkit.org/attachment.cgi?id=349118&action=review




--- Comment #44 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349118
  --> https://bugs.webkit.org/attachment.cgi?id=349118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349118&action=review

Makes sure it builds!

> Source/WebCore/dom/Element.cpp:861
> +static int adjustForZoom(int value, const Frame& frame)

Still needs a better name.

> Source/WebCore/dom/Element.cpp:866
> +    // FIXME(https://webkit.org/b/189397): Why can't we just ceil/floor?

Space after FIXME, and you can just say webkit.org/b/189397.