[webkit-reviews] review granted: [Bug 189417] [ews-build] API tests should output result in json : [Attachment 349159] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 11:04:23 PDT 2018


Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 189417: [ews-build] API tests should output result in json
https://bugs.webkit.org/show_bug.cgi?id=189417

Attachment 349159: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=349159&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 349159
  --> https://bugs.webkit.org/attachment.cgi?id=349159
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349159&action=review

> Tools/ChangeLog:3
> +	   [ews-build] API tests should output result in json

API tests should output result SUMMARY in json

> Tools/BuildSlaveSupport/ews-build/steps.py:482
> +    jsonFileName = 'api_test_results.json'

jsonFileName = 'api_test_results_summary.json'

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:931
> +	   self.jsonFileName = 'api_test_results.json'

api_test_results_summary.json


More information about the webkit-reviews mailing list