[webkit-reviews] review granted: [Bug 189044] Add specialized template declarations of HashTraits and DefaultHash to detect misuse : [Attachment 348803] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 09:53:15 PDT 2018


Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 189044: Add specialized template declarations of HashTraits and DefaultHash
to detect misuse
https://bugs.webkit.org/show_bug.cgi?id=189044

Attachment 348803: Patch

https://bugs.webkit.org/attachment.cgi?id=348803&action=review




--- Comment #16 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 348803
  --> https://bugs.webkit.org/attachment.cgi?id=348803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348803&action=review

r=me with a small nit, interesting :)

> Source/WebCore/platform/network/ProtectionSpaceHash.h:63
>	   typedef WebCore::ProtectionSpaceHash Hash;

Let's use `using Hash = WebCore::ProtectionSpaceHash`.


More information about the webkit-reviews mailing list