[webkit-reviews] review denied: [Bug 189361] [macOS] Switching to discrete GPU should be done in the UI process : [Attachment 349090] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 189361: [macOS] Switching to discrete GPU should be done in the UI process
https://bugs.webkit.org/show_bug.cgi?id=189361

Attachment 349090: Patch

https://bugs.webkit.org/attachment.cgi?id=349090&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349090
  --> https://bugs.webkit.org/attachment.cgi?id=349090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349090&action=review

This seems like a weird way to fix this bug.

> Source/WebKit/WebProcess/WebCoreSupport/mac/WebGPUClient.cpp:43
> +   
WebProcess::singleton().parentProcessConnection()->send(Messages::WebProcessPro
xy::EnableHighPerformanceGPU(), 0);

Doesn't this have to be sendSync? I would expect that we should enable the dGPU
before we continue setting up the GL context, otherwise we'll get a context
switch later.