[webkit-reviews] review granted: [Bug 189389] [iOS] Arrow keys do not dispatch DOM events : [Attachment 349101] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 189389: [iOS] Arrow keys do not dispatch DOM events
https://bugs.webkit.org/show_bug.cgi?id=189389

Attachment 349101: Patch

https://bugs.webkit.org/attachment.cgi?id=349101&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349101
  --> https://bugs.webkit.org/attachment.cgi?id=349101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349101&action=review

> Source/WebCore/ChangeLog:16
> +	   Unfortunately I ran into
<https://bugs.webkit.org/show_bug.cgi?id=189388> and hence could
> +	   not write a test for this change.

Should we fix that first so we can land with tests?

> Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:174
> +	   return "Unidentified"_s;

That's a bit weird to have in production code. Maybe return empty string?