[webkit-reviews] review granted: [Bug 189364] Actively prewarm processes created for prewarm pool : [Attachment 349059] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 13:40:16 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 189364: Actively prewarm processes created for prewarm pool
https://bugs.webkit.org/show_bug.cgi?id=189364

Attachment 349059: patch

https://bugs.webkit.org/attachment.cgi?id=349059&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 349059
  --> https://bugs.webkit.org/attachment.cgi?id=349059
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349059&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:608
> +    WebCore::ProcessWarming::prewarm();

We likely do not need the WebCore::

> Source/WebKit/WebProcess/WebProcess.h:133
> +    void prewarm();

Does this really need to be public ?


More information about the webkit-reviews mailing list