[webkit-reviews] review granted: [Bug 189360] [WHLSL] Call arguments should be copied as soon as they are evaluated : [Attachment 349045] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Thomas Denney
<tdenney at apple.com>'s request for review:
Bug 189360: [WHLSL] Call arguments should be copied as soon as they are
evaluated
https://bugs.webkit.org/show_bug.cgi?id=189360

Attachment 349045: Patch

https://bugs.webkit.org/attachment.cgi?id=349045&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 349045
  --> https://bugs.webkit.org/attachment.cgi?id=349045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review

>> Tools/WebGPUShadingLanguageRI/Evaluator.js:325
>> +	    let result = EBuffer.allowAllocation(() =>
node.func.implementation(callArguments, node));
> 
> I'm confused. Where do the thunks get evaluated? I expected this patch to
move code around, but instead it appears to be deleting code?

Got it. Looks good.