[webkit-reviews] review denied: [Bug 189057] [Curl] Stop sending request with credential if no authorization requested. : [Attachment 348350] PATCH

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 189057: [Curl] Stop sending request with credential if no authorization
requested.
https://bugs.webkit.org/show_bug.cgi?id=189057

Attachment 348350: PATCH

https://bugs.webkit.org/attachment.cgi?id=348350&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348350
  --> https://bugs.webkit.org/attachment.cgi?id=348350
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=348350&action=review

>>>
LayoutTests/http/tests/xmlhttprequest/unauthorized-without-authenticate-header.
php:21
>>> +	 req.open("GET", "<?php echo basename(__FILE__) . '?auth=1'; ?>",
false);
>> 
>> I prefer using JS API to get current URL instead of PHP.
>> window.location.href
> 
> I don't agree with that, but I can change as you wish if that is the
requirement of reviewing.

I agree with Fujii, and please don't use synchronous xmlhttprequest unless
you're explicitly testing synchronous behavior, which you're not.