[webkit-reviews] review denied: [Bug 189347] Disable test when WebAssembly not enabled : [Attachment 349023] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 6 09:42:37 PDT 2018
Mark Lam <mark.lam at apple.com> has denied Dominik Inführ <dinfuehr at igalia.com>'s
request for review:
Bug 189347: Disable test when WebAssembly not enabled
https://bugs.webkit.org/show_bug.cgi?id=189347
Attachment 349023: Patch
https://bugs.webkit.org/attachment.cgi?id=349023&action=review
--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 349023
--> https://bugs.webkit.org/attachment.cgi?id=349023
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review
>> JSTests/stress/regress-189185.js:1
>> +//@ skip if !isWebAssemblyEnabled
>
> Why not move this test into the Wasm test directory?
I agree with Saam. I should have put this test in JSTests/wasm directory. I
just wasn't aware of that option at the time. Let's move the test there
instead. Thanks.
More information about the webkit-reviews
mailing list