[webkit-reviews] review granted: [Bug 189135] BenchmarkResults.format should support specifying depth of tests to show. : [Attachment 348999] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 189135: BenchmarkResults.format should support specifying depth of tests to
show.
https://bugs.webkit.org/show_bug.cgi?id=189135

Attachment 348999: Patch

https://bugs.webkit.org/attachment.cgi?id=348999&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 348999
  --> https://bugs.webkit.org/attachment.cgi?id=348999
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348999&action=review

r=me with the suggested change.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:78
> -		   output += cls._format_tests(test['tests'], scale_unit,
show_iteration_values, indent=(indent + ' ' * len(test_name)))
> +		   output += cls._format_tests(test['tests'], scale_unit,
show_iteration_values, None if max_depth is None else max_depth - 1,
indent=(indent + ' ' * len(test_name)))

This is such a convoluted way of doing this.
Please just check: "if 'tests' in test and max_depth > 1" above.