[webkit-reviews] review granted: [Bug 188917] RELEASE_ASSERT at ../../Source/JavaScriptCore/heap/MarkedSpace.h:83 : [Attachment 348935] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 188917: RELEASE_ASSERT at ../../Source/JavaScriptCore/heap/MarkedSpace.h:83
https://bugs.webkit.org/show_bug.cgi?id=188917

Attachment 348935: Patch

https://bugs.webkit.org/attachment.cgi?id=348935&action=review




--- Comment #18 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 348935
  --> https://bugs.webkit.org/attachment.cgi?id=348935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348935&action=review

r=me if you can show that the test failures are not related to this patch.

> Source/JavaScriptCore/heap/MarkedSpace.h:88
> -	   return (index + 1) * sizeStep;
> +	   return index * sizeStep;

nit: can you express this as follows?
    size_t result = index * sizeStep;
    ASSERT(sizeClassToIndex(result) == index);
    return result;

I also recommend adding the following ASSERT in MarkedSpace.cpp's
buildSizeClassTable:
    ASSERT(MarkedSpace::sizeClassToIndex(largeCutoff - 1) <
MarkedSpace::numSizeClasses);