[webkit-reviews] review granted: [Bug 189281] Move replaceTrack logic to LibWebRTCPeerConnectionBackend : [Attachment 348926] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189281: Move replaceTrack logic to LibWebRTCPeerConnectionBackend
https://bugs.webkit.org/show_bug.cgi?id=189281

Attachment 348926: Patch

https://bugs.webkit.org/attachment.cgi?id=348926&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 348926
  --> https://bugs.webkit.org/attachment.cgi?id=348926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348926&action=review

> Source/WebCore/ChangeLog:9
> +	   This allows maing the logic easier to understand.

Nit: "This allows maing the logic" -> "This makes the logic"

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
:412
> +static inline bool tryUpdatingTrackSource(MediaStreamTrack& currentTrack,
MediaStreamTrack* newTrack, const Vector<Source>& sources)

It doesn't look like newTrack can be NULL, can you make it a MediaStreamTrack&
?