[webkit-reviews] review denied: [Bug 189053] [Curl][WebKit] Implement Proxy and TLS related features. : [Attachment 348339] PATCH

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 189053: [Curl][WebKit] Implement Proxy and TLS related features.
https://bugs.webkit.org/show_bug.cgi?id=189053

Attachment 348339: PATCH

https://bugs.webkit.org/attachment.cgi?id=348339&action=review




--- Comment #9 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 348339
  --> https://bugs.webkit.org/attachment.cgi?id=348339
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=348339&action=review

I think you should make this change testable, for example, by adding proxy and
TLS setting UI for MiniBrowser.

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:30
> +#include "NetworkProcess.h"

You don't need to add this line.

> Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp:35
> +#include <WebCore/URL.h>

You should not include URL.h because CurlProxySettings.h includes URL.h.

> Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp:134
> +    ASSERT(!settings.isEmpty());

IIUC, this assertion can fail if the client calls
WKContextSetNetworkProxySettings with kWKNetworkProxyModeCustom and an empty
proxyUrl.

> Source/WebKit/UIProcess/API/C/curl/WKContextCurl.cpp:30
> +#include "WebProcessPool.h"

Remove this blank line.
https://webkit.org/code-style-guidelines/#include-system

> Source/WebKit/UIProcess/API/C/curl/WKContextCurl.h:44
> +WK_EXPORT WKStringRef WKContextGetSslCACertPath(WKContextRef);

You are using toCopiedAPI to return a copy of string. You should name an API
Copy instead of Get if you return a copy of string in WK API.
For example, WKPageCopyTitle.
And, You should name SSL instead of Ssl, for exameple
WKContextSetAllowsAnySSLCertificateForWebSocketTesting.
WKContextGetSslCACertPath -> WKContextCopySSLCACertPath

> Source/WebKit/UIProcess/win/WebProcessPoolWin.cpp:33
> +

Remove this blank line.
https://webkit.org/code-style-guidelines/#include-system