[webkit-reviews] review granted: [Bug 189292] isAsyncGeneratorMethodParseMode() should check for SourceParseMode::AsyncGeneratorWrapperMethodMode. : [Attachment 348881] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 21:49:09 PDT 2018


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 189292: isAsyncGeneratorMethodParseMode() should check for
SourceParseMode::AsyncGeneratorWrapperMethodMode.
https://bugs.webkit.org/show_bug.cgi?id=189292

Attachment 348881: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=348881&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 348881
  --> https://bugs.webkit.org/attachment.cgi?id=348881
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=348881&action=review

r=me

Did this make any test262 tests pass?

> Source/JavaScriptCore/ChangeLog:9
> +	   Previously, it's checking for
SourceParseMode::AsyncGeneratorWrapperFunctionMode instead.

You need to rewrite this sentence

> Source/JavaScriptCore/parser/ParserModes.h:192
> +	  
SourceParseMode::AsyncGeneratorWrapperMethodMode).contains(parseMode);

Why on two lines? The indentation here looks weird (though perhaps that’s a
bugzilla bug)


More information about the webkit-reviews mailing list