[webkit-reviews] review granted: [Bug 189270] Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend : [Attachment 348857] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189270: Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
https://bugs.webkit.org/show_bug.cgi?id=189270

Attachment 348857: Patch

https://bugs.webkit.org/attachment.cgi?id=348857&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 348857
  --> https://bugs.webkit.org/attachment.cgi?id=348857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348857&action=review

> Source/WebCore/ChangeLog:8
> +	   Previously, the libwebrtc sender were owned in
LibWebRTCMediaEndpoint.

Nit: sender -> senders

> Source/WebCore/ChangeLog:9
> +	   This patch makes them owned by LibWebRTCRtpSenderBackend.

Nit: makes them owned by -> makes them be owned by

> Source/WebCore/ChangeLog:11
> +	   This will help simplifying the implementation of
RTCRtpSender::replaceTrack.

Nit: simplifying -> simplify

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:258
> +	   if (m_peerConnectionBackend.shouldOfferAllowToReceive("audio"))

Nit: "audio" -> "audio"_s

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:260
> +	   if (m_peerConnectionBackend.shouldOfferAllowToReceive("video"))

Nit: "video" -> "video"_s