[webkit-reviews] review granted: [Bug 188890] Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs : [Attachment 348783] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188890: Populate "text/uri-list" with multiple URLs when the pasteboard
contains multiple URLs
https://bugs.webkit.org/show_bug.cgi?id=188890

Attachment 348783: Patch

https://bugs.webkit.org/attachment.cgi?id=348783&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 348783
  --> https://bugs.webkit.org/attachment.cgi?id=348783
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348783&action=review

> Source/WebCore/ChangeLog:74
> +	   where the NSURL is constructed from absolute and relative parts
using a Plist. While -absoluteString gets us the
> +	   full URL string, URL::string() only returns the relative portion.

Surely there's a way to get the absolute string from a WebCore::URL?

> Source/WebCore/platform/ios/PasteboardIOS.mm:385
> +    bool isPlainTextType = [cocoaType isEqualToString:(NSString
*)kUTTypePlainText];

Sometimes you __bridge, sometimes you don't?

> Source/WebCore/platform/mac/PlatformPasteboardMac.mm:136
> +    if (NSURL *urlFromPasteboard = [NSURL URLWithString:[pasteboard
stringForType:legacyURLPasteboardType()]])

If we already have a string, why do we bounce through NSURL?

> Source/WebCore/platform/mac/PlatformPasteboardMac.mm:166
> +    if (typeIdentifier == String(kUTTypeURL)) {

Should this be case-insensitive?