[webkit-reviews] review granted: [Bug 189268] Make the jsc shell print, printErr, and debug functions more robust. : [Attachment 348836] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 189268: Make the jsc shell print, printErr, and debug functions more
robust.
https://bugs.webkit.org/show_bug.cgi?id=189268

Attachment 348836: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=348836&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 348836
  --> https://bugs.webkit.org/attachment.cgi?id=348836
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=348836&action=review

r=me.

>> Source/JavaScriptCore/jsc.cpp:1030
>> +	    scope.throwException(exec, createError(exec, "Source exhausted
encountered during UTF8 conversion"));
> 
> I should remove the "encountered" here.

What does SourceExhausted error actually mean anyway?