[webkit-reviews] review granted: [Bug 189249] [Payment Request] PaymentResponse should have an onpayerdetailchange event handler : [Attachment 348790] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 189249: [Payment Request] PaymentResponse should have an
onpayerdetailchange event handler
https://bugs.webkit.org/show_bug.cgi?id=189249

Attachment 348790: Patch

https://bugs.webkit.org/attachment.cgi?id=348790&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348790
  --> https://bugs.webkit.org/attachment.cgi?id=348790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348790&action=review

> Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp:57
> +    return
static_cast<ActiveDOMObject&>(m_request.get()).scriptExecutionContext();

You shouldn't need the static cast here.  Just
m_request->scriptExecutionContext() ought to work.