[webkit-reviews] review requested: [Bug 188996] Add IGNORE_WARNING_.* macros : [Attachment 348812] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 05:05:01 PDT 2018


Guillaume Emont <guijemont at igalia.com> has asked  for review:
Bug 188996: Add IGNORE_WARNING_.* macros
https://bugs.webkit.org/show_bug.cgi?id=188996

Attachment 348812: Patch

https://bugs.webkit.org/attachment.cgi?id=348812&action=review




--- Comment #39 from Guillaume Emont <guijemont at igalia.com> ---
Created attachment 348812

  --> https://bugs.webkit.org/attachment.cgi?id=348812&action=review

Patch

This new version should fix mac-32. A deprecated call was previously ignored
because of an erroneous diagnostic push instead of pop, I added
ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END around a GetWindowRegion() call in
WebKitLegacy/mac/Carbon/HIWebView.mm


More information about the webkit-reviews mailing list