[webkit-reviews] review granted: [Bug 189240] [EME] Add the WebM initData support in ClearKey CDM : [Attachment 348770] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 189240: [EME] Add the WebM initData support in ClearKey CDM
https://bugs.webkit.org/show_bug.cgi?id=189240

Attachment 348770: Patch

https://bugs.webkit.org/attachment.cgi?id=348770&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 348770
  --> https://bugs.webkit.org/attachment.cgi?id=348770
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348770&action=review

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:266
> +static Ref<SharedBuffer> getKeyidFromWebMInitData(const SharedBuffer&
initData)

To be coherent with the rest of the file this should be called
extractKeyIdFrom... (please, mind the capital I of KeyId).