[webkit-reviews] review granted: [Bug 189252] Move SystemPreview code from WebKitAdditions to WebKit : [Attachment 348796] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 3 17:36:53 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 189252: Move SystemPreview code from WebKitAdditions to WebKit
https://bugs.webkit.org/show_bug.cgi?id=189252

Attachment 348796: Patch

https://bugs.webkit.org/attachment.cgi?id=348796&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 348796
  --> https://bugs.webkit.org/attachment.cgi?id=348796
Patch

rs=me

You might be intending to remove these in a separate patch, but in any case, it
looks like there's some internal testing support that we don't need anymore:

  Internals::systemPreviewRelType
  Internals::isSystemPreviewLink
  Internals::isSystemPreviewImage

…as well as its usages in a few LayoutTests.


More information about the webkit-reviews mailing list