[webkit-reviews] review granted: [Bug 189227] The watchdog sometimes fails to terminate a script. : [Attachment 348787] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 3 16:04:13 PDT 2018


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 189227: The watchdog sometimes fails to terminate a script.
https://bugs.webkit.org/show_bug.cgi?id=189227

Attachment 348787: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=348787&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 348787
  --> https://bugs.webkit.org/attachment.cgi?id=348787
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=348787&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:3967
> +	   compileCheckTraps(node);

You should also call noResult here just for ensuring good style in case
CheckTraps ever gets any child nodes

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4448
> +	   compileCheckTraps(node);

Ditto


More information about the webkit-reviews mailing list