[webkit-reviews] review granted: [Bug 14590] svn-create-patch fails when svn mv is used on directory trees : [Attachment 348784] Patch v3

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 14590: svn-create-patch fails when svn mv is used on directory trees
https://bugs.webkit.org/show_bug.cgi?id=14590

Attachment 348784: Patch v3

https://bugs.webkit.org/attachment.cgi?id=348784&action=review




--- Comment #16 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 348784
  --> https://bugs.webkit.org/attachment.cgi?id=348784
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=348784&action=review

r=me

> Tools/Scripts/svn-create-patch:356
> +	       if (m/^Index: (.*)$/) {

This regular expression does not account for Windows CRLF line endings and will
capture the CR. We should make use of VCSUtils::parseDiffStartLine() (it parses
an SVN diff start and a Git diff start line in that order). If you do not like
the idea of it falling back to trying to parse a Git diff start line then we
can extract out the SVN parsing into an exported helper, say
parseSvnDiffStartLine(), and implement parseDiffStartLine() in terms of it and
then make use of parseSvnDiffStartLine() here.