[webkit-reviews] review denied: [Bug 189227] The watchdog sometimes fails to terminate a script. : [Attachment 348786] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 3 13:07:00 PDT 2018


Mark Lam <mark.lam at apple.com> has denied  review:
Bug 189227: The watchdog sometimes fails to terminate a script.
https://bugs.webkit.org/show_bug.cgi?id=189227

Attachment 348786: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=348786&action=review




--- Comment #11 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 348786
  --> https://bugs.webkit.org/attachment.cgi?id=348786
proposed patch.

This margin is still insufficient.  In the end, I cannot make this test not
racy.  I have to make the test a true infinite loop and rely on the jsc test
harness to timeout the test if it hangs.  New patch coming soon.


More information about the webkit-reviews mailing list