[webkit-reviews] review granted: [Bug 189235] [Payment Request] Implement the MerchantValidationEvent constructor : [Attachment 348757] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 189235: [Payment Request] Implement the MerchantValidationEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=189235

Attachment 348757: Patch

https://bugs.webkit.org/attachment.cgi?id=348757&action=review




--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 348757
  --> https://bugs.webkit.org/attachment.cgi?id=348757
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348757&action=review

r=me

> Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:51
>  MerchantValidationEvent::MerchantValidationEvent(const AtomicString& type,
const URL& validationURL, PaymentRequest& paymentRequest)

For your consideration, I suggest we change the data type of paymentRequest to
a Ref<PaymentRequest>&& to convey that the caller is transferring ownership.